From: Dom Lachowicz (firstname.lastname@example.org)
Date: Mon May 05 2003 - 18:46:26 EDT
A few things here:
1) Never use UT_UCS4_strcpy_char. It's not locale
safe. If you need a UTF-8 string, please use the UCS4
or UTF8 string classes.
2) When redoing a Unix dialog, please update it to use
Glade and follow the Gnome HIG. Uwog knows more about
that than most mere mortals do.
3) Wherever possible, don't use manually alloc'd/freed
UT_UCS4Char * clone;
In a class, UT_UCS4String m_foo;
in a vector:
UT_UCS4String * foo = new UT_UCS4String ();
Use the =, ==, += operators wherever possible,
.ut8_str() method where necessary for 8 bit strings.
I know this isn't all your fault, but I'm trying to
pretty-fy the code as we dig through it.
4) Explicitly break the builds on other platforms in
_updateLists (pure virtual method would do nicely)
5) When you redo the dialog, please replace
m_windowName with a UT_UTF8String. It's not your
fault, but it's fscking ugly code.
Other than that, your patch looks good and adds a lot
of nice functionality. Please send in a new one when
you've tidied up those few things. Please talk with
Uwog or me on IRC if you need further clarification or
--- Marc aka Foddex <email@example.com> wrote:
> Patch for
> I hope the code is in the style of AbiWord. I tried
> my best. If it ain't in
> the AbiWord style, blame uwog for giving me wrong
> instructions ;)
> Nah, just blame me.
> A man generally has two reasons for doing a thing.
> One that sounds good, and a real one.
> STOP MORE SPAM with the new MSN 8 and get 2 months
> ATTACHMENT part 2 application/x-tar
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
This archive was generated by hypermail 2.1.4 : Mon May 05 2003 - 18:58:55 EDT