Subject: Re: Commit -- Style dialog on Win32
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Mon Jun 04 2001 - 02:56:12 CDT
Hi Bruce,
You Rock!
On Mon, 4 Jun 2001, Bruce Pearson &/or Gwyn Ingham wrote:
> Implement the Style dialog (Top) on Win32.
>
> The following is commented out on Unix. Is there a reason for this?
> On Win32 if I uncomment and select a style in the dialog it is not set in
> the document.
This code is commented out because if you delete all styles there is no
current style and updateDocForStyleChange(getCurrentStyle(),true) will
crash.
I changed the logic in the gtk version so that this function is called if
you press "OK" upon exit from the "new" or "Modify" portions of the
dialog.
We have to do it upon exit from the "new" or "modify" dialogs because the
user may wish to change several styles with the open dialog.
Updating upon exit will only update the most recently changed dialog.
Maybe we should remove the "cancel" and "OK" buttons. Really all the User
can do from the toplevel dialog is exit it.
For the same reason maybe we should have popup window for
"delete" saying" "Are you really sure?"
Once deleted the use cannot undo the change.
Implementing undo for change sof style definitions will be really hard.
Cheers
Martin
ou can
either do things this way or we can discuss the corret way to handle
> I assume 'updateDocForStyleChange' is not working for some reason.
>
> if(m_answer == AP_Dialog_Styles::a_OK)
> {
> // getView()->getCurrentBlock()->setNeedsRedraw();
> // getDoc()->signalListeners(PD_SIGNAL_UPDATE_LAYOUT);
> }
>
> CVS: ----------------------------------------------------------------------
> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
> CVS:
> CVS: Committing in .
> CVS:
> CVS: Modified Files:
> CVS: src/af/xap/win/xap_Win32DialogHelper.cpp
> CVS: src/af/xap/win/xap_Win32DialogHelper.h
> CVS: src/wp/ap/win/ap_Win32Dialog_Styles.cpp
> CVS: src/wp/ap/win/ap_Win32Dialog_Styles.h
> CVS: src/wp/ap/win/ap_Win32Resources.rc2
> CVS: Added Files:
> CVS: src/wp/ap/win/ap_Win32Res_DlgStylesTop.rc2
> CVS: ----------------------------------------------------------------------
>
>
>
This archive was generated by hypermail 2b25 : Mon Jun 04 2001 - 02:56:32 CDT